Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transmissions : makes "from" address optional for use with templates #129

Merged
merged 1 commit into from Jun 29, 2016
Merged

Transmissions : makes "from" address optional for use with templates #129

merged 1 commit into from Jun 29, 2016

Conversation

conradkleinespel
Copy link
Contributor

@conradkleinespel conradkleinespel commented Jun 29, 2016

Hello !

Thanks for the 2.0 update, it makes a lot of sense, and removes the deprecated Ivory dependency, so good ! 👍

Unfortunately, at the moment, it seems like adding a From address is a hard requirement, even when using templates (which you can set up the From address for in the Sparkpost UI).

This fixes this use case. I didn't dive to deep into the details : maybe there should be some additional checks in case we are not using a template, in which case a From would indeed be needed.

Just wanted to get feedback first.

Best regards,
Conrad @ reassurez-moi.fr

@richleland richleland merged commit 40558e0 into SparkPost:master Jun 29, 2016
1 check passed
@richleland
Copy link
Contributor

@richleland richleland commented Jun 29, 2016

Awesome we were just talking about this issue today @conradkleinespel - thanks! I'll make a patch release here in a few minutes.

@conradkleinespel conradkleinespel deleted the from-fix branch Jun 29, 2016
@conradkleinespel
Copy link
Contributor Author

@conradkleinespel conradkleinespel commented Jun 29, 2016

@richleland Awesome, thanks for the quick reaction time 👍

@richleland
Copy link
Contributor

@richleland richleland commented Jun 29, 2016

np! 2.0.1 is now available.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants