Transmissions : makes "from" address optional for use with templates #129
Conversation
|
Awesome we were just talking about this issue today @conradkleinespel - thanks! I'll make a patch release here in a few minutes. |
|
@richleland Awesome, thanks for the quick reaction time |
|
np! 2.0.1 is now available. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Hello !
Thanks for the 2.0 update, it makes a lot of sense, and removes the deprecated Ivory dependency, so good !👍
Unfortunately, at the moment, it seems like adding a
Fromaddress is a hard requirement, even when using templates (which you can set up theFromaddress for in the Sparkpost UI).This fixes this use case. I didn't dive to deep into the details : maybe there should be some additional checks in case we are not using a template, in which case a
Fromwould indeed be needed.Just wanted to get feedback first.
Best regards,
Conrad @ reassurez-moi.fr